WIP: Add intel vsp #210
WIP: Add intel vsp #210
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bn222 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test make-e2e-test |
|
/test remaining-required |
|
/test make-e2e-test |
1 similar comment
|
/test make-e2e-test |
go get github.com/intel/ipu-opi-plugins
|
/test remaining-required |
| FROM registry.ci.openshift.org/ocp/4.18:base-rhel9 | ||
|
|
||
| COPY --from=builder /usr/src/ipu-opi-plugin/bin/ipuplugin /usr/bin/ | ||
| COPY cmd/intelvsp/fxp-net_linux-networking.pkg / |
There was a problem hiding this comment.
@bn222 latest ipu-plugin code uses P4_NAME in Makefile(https://github.com/intel/ipu-opi-plugins/blob/main/ipu-plugin/Makefile#L5), and exports env variable->P4_NAME in Dockerfile(https://github.com/intel/ipu-opi-plugins/blob/main/ipu-plugin/images/Dockerfile#L16) , and uses it in the code(thro getenv) in lifecycleservice.go->https://github.com/intel/ipu-opi-plugins/blob/main/ipu-plugin/pkg/ipuplugin/lifecycleservice.go#L542
There was a problem hiding this comment.
There was a problem hiding this comment.
We can't have that as variables at this level, hence I've replaced the vars with what we are using.
Also, since there is code that reads the env var (which we should remove, and use a proper function to set it), I've added it to the call-site.
|
/test remaining-required |
|
/test make-e2e-test |
1 similar comment
|
/test make-e2e-test |
|
@bn222: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
We will need a go mod tidy/vendor with the latest changes to ipu-p4-plugin |
No description provided.