Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add intel vsp #210

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

WIP: Add intel vsp #210

wants to merge 4 commits into from

Conversation

bn222
Copy link
Contributor

@bn222 bn222 commented Nov 16, 2024

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2024
Copy link

openshift-ci bot commented Nov 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bn222

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2024
@bn222
Copy link
Contributor Author

bn222 commented Nov 16, 2024

/test make-e2e-test

@openshift-ci-robot
Copy link

/test remaining-required

@bn222
Copy link
Contributor Author

bn222 commented Nov 17, 2024

/test make-e2e-test

1 similar comment
@vrindle
Copy link
Contributor

vrindle commented Nov 17, 2024

/test make-e2e-test

@bn222
Copy link
Contributor Author

bn222 commented Nov 18, 2024

@sudhar-krishnakumar

@openshift-ci-robot
Copy link

/test remaining-required

FROM registry.ci.openshift.org/ocp/4.18:base-rhel9

COPY --from=builder /usr/src/ipu-opi-plugin/bin/ipuplugin /usr/bin/
COPY cmd/intelvsp/fxp-net_linux-networking.pkg /
Copy link
Contributor

@sudhar-krishnakumar sudhar-krishnakumar Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't have that as variables at this level, hence I've replaced the vars with what we are using.

Also, since there is code that reads the env var (which we should remove, and use a proper function to set it), I've added it to the call-site.

@openshift-ci-robot
Copy link

/test remaining-required

@vrindle
Copy link
Contributor

vrindle commented Nov 19, 2024

/test make-e2e-test

1 similar comment
@bn222
Copy link
Contributor Author

bn222 commented Nov 20, 2024

/test make-e2e-test

Copy link

openshift-ci bot commented Nov 20, 2024

@bn222: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@SalDaniele
Copy link
Contributor

We will need a go mod tidy/vendor with the latest changes to ipu-p4-plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants